Add Russian and Simplified Chinese voice notifications - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ru) and Simplified Chinese (zh-CN) for both bundled voices and all ten lifecycle eventszh-CNhandling and bounded PowerShell inputWhy
Voice Notify previously bundled Korean, Japanese, and English only. This release adds Russian and Simplified Chinese while preserving offline playback, existing defaults, and the privacy boundary around hook payloads.
The first cross-platform CI run also exposed platform-specific CRLF checkout bytes in otherwise deterministic ZIPs. Repository-wide LF attributes now remove that source of drift, and CI compares the validated macOS and Windows ZIP digests directly.
User impact
Users can select
ruorzh-CNwith either bundled voice on macOS and Windows. Generic Chinese requests default to the bundled Simplified Chinese variant. No conversation content is sent over the network or retained by the plugin.Validation
566f67382ae36bbd0bccf615fd1eff93729d1deff980fe5a03fd3ee4d4ccff3egit diff --checkCI run: https://github.com/battle-doll/codex-voice-notify/actions/runs/31618280799