Prevent apt lockfiles from containing multiple versions - #252
Open
hartikainen wants to merge 2 commits into
Open
hartikainen wants to merge 2 commits into
hartikainen wants to merge 2 commits into
Conversation
hartikainen
changed the title
apt locfiles from containing multiple versionsapt lockfiles from containing multiple versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to solve #251, i.e. to prevent
aptlockfiles from containing multiple versions of the same Debian package for one target architecture. Separate root closures can currently select that package from different suites, causing both.debarchives to be included even when one version satisfies both closures.I expected one selected record for each
(Package, target architecture)identity, but observed bothnoble/libssl3t64:amd64=3.0.13-0ubuntu3andnoble-updates/libssl3t64:amd64=3.0.13-0ubuntu3.9.The first commit adds a regression test reproducing the duplicate package and stale dependency edge. The second commit indexes packages by name and target architecture while constructing the lock, retains the first selected package, and resolves dependency edges through that same index. The serialized lock key format and
Architecture: allexpansion remain unchanged.I tested this in my downstream application and it seems to fix the problem. That said, I'm a newbie here so I'm not sure if this is the right way to handle this.
For transparency: I both investigated this and implement the fix with heavy help from Opus.
Fixes #251.