Skip to content

feat(apt): add OpenPGP signature verification for apt repository indices - #255

Open
loosebazooka wants to merge 1 commit into
bazel-contrib:mainfrom
loosebazooka:gpg-verify
Open

loosebazooka wants to merge 1 commit into
bazel-contrib:mainfrom
loosebazooka:gpg-verify

Conversation

@loosebazooka

@loosebazooka loosebazooka commented Aug 28, 2026

Copy link
Copy Markdown
Contributor
  • Verify InRelease / Release.gpg signatures via gpgv or sqv and enforce Release SHA256 checksums on package indices.
  • Now requiring either gpg_keys or explicit allow_unsigned = True.
  • Auto-dearmor ASCII-armored .asc keyrings (requires sq or gpg)

What breaks: Any existing apt.sources_list in a user's MODULE.bazel that does not specify gpg_keys will now fail Bazel evaluation with a clear error message.

How users migrate: Users must do one of two things:

  1. Supply keyring(s) (recommended):
apt.sources_list(
    gpg_keys = ["//keys:debian-archive-keyring.asc"],
    ...
)

1.. Explicitly opt out of verification:

apt.sources_list(
    allow_unsigned = True,
    ...
)

@loosebazooka
loosebazooka force-pushed the gpg-verify branch 2 times, most recently from fae6790 to 1d95a0b Compare August 31, 2026 19:23
Comment thread apt/extensions.bzl Outdated
Comment thread e2e/smoke/MODULE.bazel Outdated
@loosebazooka
loosebazooka force-pushed the gpg-verify branch 8 times, most recently from 16a5987 to c6d64fd Compare September 3, 2026 15:04
@loosebazooka loosebazooka changed the title WIP add pgp verification feat(apt): add OpenPGP signature verification for apt repository indices Sep 3, 2026
@loosebazooka
loosebazooka marked this pull request as ready for review September 3, 2026 15:17
@loosebazooka
loosebazooka marked this pull request as draft September 11, 2026 15:54
@loosebazooka
loosebazooka force-pushed the gpg-verify branch 9 times, most recently from 2c3e68b to 8dcaf0c Compare September 11, 2026 21:07
@loosebazooka
loosebazooka marked this pull request as ready for review September 11, 2026 21:10
@loosebazooka

Copy link
Copy Markdown
Contributor Author

oh lemme rebase this. FYI it is a breaking change (required attribute)

- Verify InRelease / Release.gpg signatures via gpgv or sqv and enforce Release SHA256 checksums on package indices.
- Now requiring either gpg_keys or explicit allow_unsigned = True.
- Auto-dearmor ASCII-armored .asc keyrings (requires sq or gpg)
- A new e2e test for test failure

Signed-off-by: Appu <appu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants