Conversation
|
Yeah this is probably blocking some updates from being simple. I'll take a look |
|
We probably don't want to keep the old api shape. i am thinking this could be something like |
|
That feels like it's well outside the scope of this PR? This is meant to be a very light-touch bugfix (it's only ten lines, after all); @thesayyn's comment is referring to a feature request that implements a breaking API change and adds a whole new tag in the module extension and then pipes it through to I would update my code that depends on |
|
I did not mean to sign you up for a work that you did not want. I was simply explaining the path forward for this feature which also tries to explain why it was removed in the first place. |
|
As long as you also believe that it should not have been removed yet, given that the path forward does not currently exist, we are in agreement. |
Somewhere in the shuffle of the refactoring of
apt.install, this attr seems to have been dropped. It is vitally important if you want to use thedpkg_statusdrule provided by//apt:defs.bzl, as can be seen in thedistrolessrepo here: https://github.com/GoogleContainerTools/distroless/blob/2958d510e6e7dcaa1f546042cfca98930a60a2ce/private/repos/deb/deb.MODULE.bazel#L21This PR just re-adds the
package_templateparameter and re-pipes it through totranslate_dependency_set, following the example of the PR that re-addsmergedusrhere: #244I have tested this change locally in my project that depends on
rules_distrolessand confirmed that it works as intended.