perf: avoid repeated apt repository metadata - #270
Open
zbarsky-openai wants to merge 4 commits into
Open
zbarsky-openai wants to merge 4 commits into
zbarsky-openai wants to merge 4 commits into
Conversation
Use tar.bzl's pinned host binary during repository evaluation. Discover the data archive instead of assuming XZ compression, so Zstandard debs work without host tar or zstd. Remove directory exclusions that suppress file discovery with BSD tar, and report inspection/extraction failures.
Keep indexes from different URLs separate even when suite, component, and architecture match. Scope snapshot facts by source URL and retain the selected package's URLs instead of reconstructing them from the suite. Continue reading existing v2 locks and refresh their provenance when packages are resolved. Cover mixed snapshot/rolling sources and package URLs that differ from the suite's URLs.
Inspect the exact selected Debian archive only when a dependency file map is needed. Avoid downloading and parsing distribution-wide Contents indexes, which third-party apt repositories may not publish and which do not identify the selected package version. Delete the temporary archive after inspection and remove the unused Contents parser.
Store each package key in its leaf file map and reconstruct ordered dependency keys from those maps. Derive the repository target name from the canonical repository name using the existing helper. This avoids duplicating dependency lists and names across generated repository specifications in MODULE.bazel.lock without changing generated targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store each package key alongside its installed paths in the leaf file
map. Reconstruct dependency keys from those maps in resolver order,
preserving the first dependency that provides a file.
Derive repository target names from the canonical repository name with
the existing helper. This removes repeated dependency lists and target
names from generated MODULE.bazel.lock repository specifications while
preserving the generated targets and dependency order.
Depends on #269. The branch includes that PR and its prerequisites; the
metadata change is commit a699927.