fix(rpm): debuginfo support on more distributions #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdesgroppes
force-pushed
the
fix-rpm-debuginfo-on-ubuntu
branch
12 times, most recently
from
2056729 to
1a89eb1
Compare
rdesgroppes
changed the title
rdesgroppes
force-pushed
the
fix-rpm-debuginfo-on-ubuntu
branch
2 times, most recently
from
5dbe86a to
d618ca4
Compare
rdesgroppes
requested review from
aiuto,
cgrindel,
meteorcloudy and
nacl
as code owners
rdesgroppes
force-pushed
the
fix-rpm-debuginfo-on-ubuntu
branch
from
d618ca4 to
85bada1
Compare
cgrindel
reviewed
Jan 24, 2026
Collaborator
cgrindel
left a comment
cgrindel
left a comment
There was a problem hiding this comment.
The change looks reasonable to me. However, there appear to be some CI failures.
This enables RPM debuginfo package generation across different Linux distributions (tested on Rocky and Ubuntu in CI) by implementing RPM version-based detection if possible, and falling back to the existing OS release-based detection otherwise. There's indeed a clear pivot in RPM versions for that matter: - RPM < 4.18 uses `buildsubdir .` (which happens to be called the "CENTOS" type in the present project), - RPM >= 4.18 is incompatible with the former: ``` rm: refusing to remove '.' or '..' directory: skipping '.' ``` It therefore uses `buildsubdir BUILD_SUB` (called the "FEDORA" type here). RedHat distros have `redhat-rpm-config` with `%_enable_debug_packages` that auto-invokes `%debug_package` (rpm-software-management/rpm#2204). Debian/Ubuntu ship vanilla upstream RPM without this configuration: ``` output 'tests/rpm/test_debuginfo_rpm-debuginfo-1-0..rpm' was not created ``` The present change therefore adds `%debug_package` only when applicable: `%{!?_enable_debug_packages:%debug_package}`. Also, since RPM 4.14, unique debug package filenames are enabled by default, leading to variadic filenames being generated: ``` Executing tests from //tests/rpm:test_golden_debuginfo_rpm_contents ----------------------------------------------------------------------------- 29c29 < /usr/lib/debug/test_debuginfo-1-0.x86_64.debug --- > /usr/lib/debug/test_debuginfo.debug FAIL: files "tests/rpm/test_debuginfo_rpm_contents.txt" and "tests/rpm/test_debuginfo_rpm_contents.txt.golden" differ ``` The change makes debug package filenames consistent across distributions by means of: `%undefine _unique_debug_names` (safe no-op on older RPM versions).
rdesgroppes
force-pushed
the
fix-rpm-debuginfo-on-ubuntu
branch
from
b358709 to
15c0143
Compare
Collaborator
|
@kellyma2 IIRC, you're the only one who knows about rpm debug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables RPM debuginfo package generation across different Linux distributions (tested on Rocky and Ubuntu in CI) by implementing RPM version-based detection if possible, and falling back to the existing OS release-based detection otherwise.
There's indeed a clear pivot in RPM versions for that matter:
buildsubdir .(which happens to be called the "CENTOS" type in the present project),buildsubdir BUILD_SUB(called the "FEDORA" type here).RedHat distros have
redhat-rpm-configwith%_enable_debug_packagesthat auto-invokes%debug_package(rpm-software-management/rpm#2204). Debian/Ubuntu ship vanilla upstream RPM without this configuration:The present change therefore adds
%debug_packageonly when applicable:%{!?_enable_debug_packages:%debug_package}.Also, since RPM 4.14, unique debug package filenames are enabled by default, leading to variadic filenames being generated:
The change makes debug package filenames consistent across distributions by means of:
%undefine _unique_debug_names(safe no-op on older RPM versions).