fix(test): make //distro:packaging_test work with Bazel 9
#1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdesgroppes
force-pushed
the
fix-packaging-test-with-bazel-9
branch
5 times, most recently
from
dff982e to
248aac6
Compare
cgrindel
reviewed
Jan 24, 2026
Collaborator
cgrindel
left a comment
cgrindel
left a comment
There was a problem hiding this comment.
This looks reasonable to me. However, I noticed some CI failures.
Bazel 9 flipped `--incompatible_strict_action_env` to `true` by default (bazelbuild/bazel#27670), which means tests no longer inherit `PATH` from the host environment. This breaks subprocess calls that rely on `PATH` lookup: ``` ==================== Test output for //distro:packaging_test: E. ====================================================================== ERROR: testBuild (__main__.PackagingTest.testBuild) ---------------------------------------------------------------------- Traceback (most recent call last): [...] build_result = subprocess.check_output(['bazel', 'build', '--enable_workspace', ':dummy_tar']) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [...] FileNotFoundError: [Errno 2] No such file or directory: 'bazel' ``` This change therefore adds `env_inherit = ["PATH"]` to that very test, which matches the behavior of earlier Bazel versions and is consistent with the presence of a "noci" tag. Additionally, Bazel 9 removed `WORKSPACE` support entirely (bazelbuild/bazel#26131), requiring `bzlmod` with `MODULE.bazel`: ``` ==================== Test output for //distro:packaging_test: [...] WARNING: --enable_bzlmod is set, but no MODULE.bazel file was found at the workspace root. Bazel will create an empty MODULE.bazel file. Please consider migrating your external dependencies from WORKSPACE to MODULE.bazel. For more details, please refer to bazelbuild/bazel#18958. [...] ERROR: error loading package '': Unable to find package for @@[unknown repo 'not_named_rules_pkg' requested from @@]//pkg:tar.bzl: The repository '@@[unknown repo 'not_named_rules_pkg' requested from @@]' could not be resolved: No repository visible as '@not_named_rules_pkg' from main repository. [...] ERROR: Build did NOT complete successfully E. ====================================================================== ERROR: testBuild (__main__.PackagingTest.testBuild) ---------------------------------------------------------------------- [...] build_result = subprocess.check_output(['bazel', 'build'] + bazel_flags + [':dummy_tar']) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [...] subprocess.CalledProcessError: Command '['bazel', 'build', '--enable_workspace', ':dummy_tar']' returned non-zero exit status 1. ``` The test now detects the Bazel version at runtime and generates the appropriate setup: - Bazel 9+: `MODULE.bazel`, with `bazel_dep` and `archive_override`, - earlier versions, as before: `WORKSPACE`, with `http_archive` and `--enable_workspace` flag. For good measure, the change also addresses a leftover TODO by replacing the `tar` subprocess invocation with pure Python code (as otherwise done in the repo).
rdesgroppes
force-pushed
the
fix-packaging-test-with-bazel-9
branch
from
248aac6 to
385b4ee
Compare
aiuto
approved these changes
Jan 28, 2026
Collaborator
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
It's fine, but too much. We'll never build the distribution with anything less than bazel 8.
| with tarfile.open('bazel-bin/dummy_tar.tar.gz', 'r') as tar: | ||
| self.assertEqual(['etc', 'etc/BUILD'], tar.getnames()) | ||
|
|
||
| def _select_bazel_supported_setup(self): |
Collaborator
There was a problem hiding this comment.
We only have to support building the distro from bazel 8+,
so a module is always available. The workspace test is essentaally dead code to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel 9 flipped
--incompatible_strict_action_envtotrueby default (bazelbuild/bazel#27670), which means tests no longer inheritPATHfrom the host environment. This breaks subprocess calls that rely onPATHlookup:This change therefore adds
env_inherit = ["PATH"]to that very test, which matches the behavior of earlier Bazel versions and is consistent with the presence of a"noci"tag.Additionally, Bazel 9 removed
WORKSPACEsupport entirely (bazelbuild/bazel#26131), requiringbzlmodwithMODULE.bazel:The test now detects the Bazel version at runtime and generates the appropriate setup:
MODULE.bazel, withbazel_depandarchive_override,WORKSPACE, withhttp_archiveand--enable_workspaceflag.For good measure, the change also addresses a leftover TODO by replacing the
tarsubprocess invocation with pure Python code (as otherwise done in the repo).