fix: race condition in AddToContext#5
Merged
bborbe merged 4 commits intobborbe:masterfrom Feb 12, 2026
Merged
Conversation
The previous implementation mutated a shared map stored in the context, which could cause data corruption when multiple goroutines called AddToContext on contexts derived from the same parent. This fix creates a new map for each call, copying existing data, ensuring no shared mutable state. The global mutex is no longer needed and has been removed.
- Test that derived contexts maintain independent data - Test concurrent access from multiple goroutines (run with -race)
bborbe
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
AddToContextfunction mutated a shared map stored in the context. When multiple goroutines calledAddToContexton contexts derived from the same parent, they would corrupt each other's data.The mutex only protected the write operation, but the map itself was shared across all derived contexts.
Solution
Create a new map for each call, copying existing data:
This ensures no shared mutable state. The global mutex has been removed as it's no longer needed.