fix: race condition in resetLogLevel#7
Merged
bborbe merged 3 commits intobborbe:masterfrom Feb 12, 2026
Merged
Conversation
- Add mutex lock to resetLogLevel() to prevent data race when reading lastSetTime - Use context.Background() for reset goroutine to ensure reset happens after the full duration, regardless of caller's context cancellation - Add concurrent access test (run with -race flag) - Fix typo: 'to short' -> 'too short'
bborbe
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two issues in
logLevelSetter:1. Data race in
resetLogLevel()2. Context cancellation triggers early reset
The reset goroutine inherited the caller's context, so if an HTTP request finished early, the log level would reset prematurely.
Solution
l.mux.Lock()toresetLogLevel()context.Background()for the reset timer-raceflag)