Fix timeout test mock in test_claude_analyzer#6
Merged
bborbe merged 1 commit intobborbe:masterfrom Mar 10, 2026
Merged
Conversation
The test patched asyncio.wait_for to raise TimeoutError, but asyncio.create_subprocess_exec fails first with FileNotFoundError (claude binary not installed on CI), so the mock was never triggered. Mock _run_claude directly to raise TimeoutError, which correctly tests the retry/timeout handling in _verify_claude_auth_impl. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bborbe
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_auth_times_out_after_30_secondsfailing on CIRoot Cause
The test patched
asyncio.wait_forto raiseTimeoutError, but_run_claude()callsasyncio.create_subprocess_execfirst — which raisesFileNotFoundErroron CI (noclaudebinary installed). TheFileNotFoundErrorpropagates beforewait_foris ever reached, so the mock never fires and the test gets a generic error message instead of the expected "timed out" message.Fix
Mock
_run_claudedirectly to raiseTimeoutErrorinstead of patchingasyncio.wait_for. This correctly tests the retry/timeout handling logic in_verify_claude_auth_implwithout depending on internal implementation details of_run_claude.Validation
ruffandmypychecks pass🤖 Generated with Claude Code