Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So when I tried just updating the about to 1.6, I was getting errors. The mod's menu had the options, but none of the palettes, and caused the log to flood with errors. I was also getting an error related to the transpiler in Log_Notify_MessageReceivedThreadedInternal_Modify_Patch failing, with "FishTranspiler.Replace couldn't find target instruction" because it was looking for the constant 1000. After running some debug to determine what instructions were being sent, I was able to see that RimWorld 1.6 changed the log message limit from 1000 to 10000.
Fix: Updated the transpiler condition from code.operand is 1000 to code.operand is 10000 to match RimWorld 1.6's actual constant value. Also updated the description to clarify that 1.6 uses 10000 messages while older versions used 1000.
Root cause: RimWorld 1.6 increased the default log message limit from 1000 to 10000, so the transpiler's pattern matching needed to be updated accordingly.
The mod should now work correctly in RimWorld 1.6 while maintaining compatibility with older versions.