Handle parallel cores and Windows cluster cleanup#8
Open
Auxes1s wants to merge 1 commit into
Open
Conversation
In bootstrap(), ensure the `cores` argument is set to NULL when parallel flag `pl` is not TRUE, and on Windows create a parallel cluster object when `cores` is a single numeric > 1. Also register an on.exit() to stop the cluster, preventing orphaned worker processes. These changes make pblapply() receive an appropriate `cl` and ensure proper cleanup on Windows when using multiple cores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In bootstrap(), ensure the
coresargument is set to NULL when parallel flagplis not TRUE, and on Windows create a parallel cluster object whencoresis a single numeric > 1. Also register an on.exit() to stop the cluster, preventing orphaned worker processes. These changes make pblapply() receive an appropriatecland ensure proper cleanup on Windows when using multiple cores.