[SMT-63] Header colours bugfix and pipeline changes#697
Merged
Conversation
- Patched the pipeline so deploy reruns recover from that case instead of failing immediately. In .pipeline/lib/ deploy.js:10, the deploy now checks whether the required versioned images exist in d3d940-tools; if they are missing, it rebuilds them from the checked-out commit before calling importImageStreams. - Also made the build helper return its promise in .pipeline/lib/build.js:5, and updated the entrypoints in .pipeline/build.js:1 and .pipeline/deploy.js:1 to fail cleanly on async errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SMT-63] Fix an issue where header colours are overridden
Pipeline stuff
Patched the pipeline so deploy reruns recover from that case instead of failing immediately. In .pipeline/lib/
deploy.js:10, the deploy now checks whether the required versioned images exist in d3d940-tools; if they are missing,
it rebuilds them from the checked-out commit before calling importImageStreams.
Also made the build helper return
its promise in .pipeline/lib/build.js:5, and updated the entrypoints in .pipeline/build.js:1 and .pipeline/deploy.js:1
to fail cleanly on async errors.