#5821 - Partner programs go to pending#5888
Merged
weskubo-cgi merged 2 commits intomainfrom Mar 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Education Program Form.io definition to refine partner-institution messaging and adjust how program status is derived when a program is offered jointly/with partner institutions.
Changes:
- Updates partner-institution designation question text and adds
validateWhenHidden: falseto avoid validating the hidden required field. - Adds a new conditional warning banner (“Partner program review”) when partner institutions are designated.
- Adjusts
programStatuscalculation to mark programs asPendingwhenhasJointInstitution === "yes", and fixes minor punctuation in an existing warning banner.
sources/packages/forms/src/form-definitions/educationprogram.json
Outdated
Show resolved
Hide resolved
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
reviewed
Mar 12, 2026
| }, | ||
| { | ||
| "label": "Are all institutions you partner with for this program designated by Student Aid BC?", | ||
| "label": "Are all institutions you partner with for this program designated by StudentAid BC?", |
Collaborator
There was a problem hiding this comment.
Minor. AC states designated with
Collaborator
Author
There was a problem hiding this comment.
I discussed this previously with Josh and the AC will be updated as we are sticking with "by".
dheepak-aot
reviewed
Mar 12, 2026
| "value": "" | ||
| } | ||
| ], | ||
| "content": "<strong> This program is ineligible for StudentAid BC funding.</strong><br/>\nAll partner institutions must be designated by StudentAid BC..", |
dheepak-aot
approved these changes
Mar 12, 2026
Collaborator
dheepak-aot
left a comment
dheepak-aot
left a comment
There was a problem hiding this comment.
Nice work @weskubo-cgi. Looks good 👍
tiago-graf
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Screenshots
Institution - Add Program
Designated banner
Non-designated banner
Institution - Programs
Shows status on create
