#5687 - Disable View assessment when assessment data not available#5892
Open
weskubo-cgi wants to merge 2 commits intomainfrom
Open
#5687 - Disable View assessment when assessment data not available#5892weskubo-cgi wants to merge 2 commits intomainfrom
weskubo-cgi wants to merge 2 commits intomainfrom
Conversation
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Assessment history UI logic to avoid showing the View action when the assessment data is not available (e.g., when supporting user information is pending), aligning the History table behavior with cases where the assessment cannot actually be viewed.
Changes:
- Updates the Assessment history table to show the View button only when
assessmentDateis present and the row is not an unsuccessful-weeks entry. - Refactors the visibility condition into a dedicated
showViewButtonhelper for clarity/reuse.
sources/packages/web/src/components/common/students/assessment/History.vue
Show resolved
Hide resolved
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Screenshots
Ministry - Supporting User declaration pending (View hidden)
Ministry - Unsuccessful Completion (View hidden - existing logic)
Ministry - View shown
Student - View shown
Institution - View shown