Skip to content

feat: increase unit test coverage for Host app#1087

Merged
dimak1 merged 2 commits intobcgov:mainfrom
dimak1:feat/unit-test-coverage
Mar 10, 2026
Merged

feat: increase unit test coverage for Host app#1087
dimak1 merged 2 commits intobcgov:mainfrom
dimak1:feat/unit-test-coverage

Conversation

@dimak1
Copy link
Collaborator

@dimak1 dimak1 commented Mar 10, 2026

Issue:

Description of changes:

  • Increase unit test coverage for Host app to 80%+
Screenshot 2026-03-10 at 14 53 59

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

@dimak1 dimak1 self-assigned this Mar 10, 2026
@dimak1 dimak1 added the Host label Mar 10, 2026
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-1087-s5dpoohu.web.app

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see 10 SC issues. I think they're all straightforward and easy to fix

@sonarqubecloud
Copy link

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!! 👍

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://strr-hosts-dev--pr-1087-s5dpoohu.web.app

Copy link
Collaborator

@jimmypalelil jimmypalelil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM 👍

@dimak1 dimak1 merged commit 71e3781 into bcgov:main Mar 10, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants