feat(examiner-ui): display days-ago and today for expiry countdown in application and registration info header#1093
Open
jimmypalelil wants to merge 1 commit intobcgov:mainfrom
Conversation
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1093-senxr375.web.app |
… application and registration info header Add getExpiryCountdown() in base-web with en-CA/fr-CA i18n. Use in ApplicationInfoHeader and RegistrationInfoHeader for NOC and registration expiry. Replace generic 'EXPIRED' with 'X days ago' and show 'today' for same-day expiry. Add unit tests for expiry label scenarios.
jimmypalelil
force-pushed
the
32631-display-days-ago-expiry
branch
from
59f2597 to
6a66420
Compare
|
Collaborator
|
Temporary Url for review: https://strr-examiner-dev--pr-1093-senxr375.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Description of changes:
getExpiryCountdown()inaccountDashHelpers.tsto compute label and numeric value for styling/sorting; added i18n keysexpiryDaysLeft,expiryDaysAgo,expiryTodayin en-CA and fr-CA.ApplicationInfoHeader.vueandRegistrationInfoHeader.vuenow use the shared countdown helper for NOC and registration expiry; expiry text is shown in parentheses with red styling when expired.registration-details.spec.tsupdated to cover future/today/past expiry label scenarios (with mockedgetExpiryCountdown).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License