Open
Conversation
|
asinn134
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Objective
MDS-6802
Description
This PR resolves an issue in the now tier History Modal where timestamps were displaying an incorrect time, shifted by the local timezone offset.
Root Cause:
The backend
HistoryMixin(which provides the history trail) was exposing UTC timestamps in its JSON payload without providing the timezone offset suffix. The frontend received2026-04-08T20:42:00and parsed it locally, incorrectly resolving it as8:42 PMlocal time rather than extracting the local equivalent from UTC.Fix:
Wrapped the
updated_atmapping inmodels_mixins.pywith the existingdt_to_strhelper. This ensures the output string adheres to ISO8601 formatting and includes the+00:00UTC offset indicator, allowingmoment.jsto parse it correctly into the user's local timezone.Side Effects Analysis:
The
HistoryMixinis also utilized by Tailings Storage Facilities (TSFs) and Dams.TailingsDiffModal.tsxandDiffTable.tsx) run theupdated_atAPI output through aformatDatehelper rather thanformatDateTime. TheformatDatehelper forces strict parsing against the"YYYY-MM-DD"format. This hard-strips out the time and ignores the new+00:00suffix. As a result, there are zero visual side effects on existing TSF or Dam history tables.Manual Test Plan
MMM DD YYYY(e.g.,Apr 08 2026) without displaying the time.