Feature solr merged#1965
Merged
hfekete merged 20 commits intobcgov:feature-solr-mergedfrom Mar 5, 2026
Merged
Conversation
…cgov#1944) * fix - Add dataclass-based dynamic attribute initialization * test - Add unit tests for `PaymentToken` and `ReceiptResponse` dataclasses and refactor initialization logic * refactor - Replace `from_dict` methods with Pydantic-based dataclass initialization across `PaymentToken` and `ReceiptResponse` for consistent and simplified validation * test - Add unit tests for `PaymentInvoice` dataclass and refactor to use Pydantic initialization * refactor - Update `links` field in Pydantic model to use alias "_links" for consistency * test/refactor - Add `invoice` field support in `ReceiptResponse` with tests and update `links` alias logic * refactor/tests - Update DB connection logic for tests, add refund field, and improve type handling in tests * test - Enhance `PaymentInvoice` tests to validate numeric types and use `pytest.approx` for floating-point assertions * test/refactor - Replace hardcoded assertions in `test_payment_invoice` with dynamic checks using `data` dictionary * test - Add `PaymentRefundInvoice` dataclass, update `refund_payment` logic, and add unit tests
perf: configure container concurrency to 20 and max scale to 60 for Namex services
* 32058-Update "create account" url for email templates. * Update create account links.
Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239-Fix CI - bad-designation-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32438-Add John Andrews to Reports Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32438-Add John Andrews to Reports Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32438-Add John Andrews to Reports Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32239 Fix Bad Designation Norifier CI and add John Andrews to Reports
32239-Fix CI - bad-designation-notifier
…ethods to By locators. Add environment flag to skip authentication in tests.
Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI-namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32240-Fix CI and lint - sftp-nuans-report Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier Signed-off-by: Chen <Steven.Chen@gov.bc.ca> 32238-Fix CI - namex-bad-name-notifier and sftp_nuans_report
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
Fix CI-namex-bad-name-notifier and sftp-nuans-report
Signed-off-by: Chen <Steven.Chen@gov.bc.ca>
32238-Fix CI - namex-bad-name-notifier
hfekete
requested review from
davemck513,
mengdong19,
ozamani9gh,
rarmitag and
stevenc987
as code owners
|
stevenc987
reviewed
Mar 5, 2026
Collaborator
stevenc987
left a comment
stevenc987
left a comment
There was a problem hiding this comment.
Do you need to increase version for this change?
mengdong19
approved these changes
Mar 5, 2026
stevenc987
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
missing functions after merge
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).