Skip to content
This repository was archived by the owner on Apr 30, 2026. It is now read-only.

fix: github manual relase#104

Merged
mishraomp merged 2 commits into
mainfrom
fix/github-manual-release
Jun 17, 2025
Merged

fix: github manual relase#104
mishraomp merged 2 commits into
mainfrom
fix/github-manual-release

Conversation

@mishraomp
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the release workflow by introducing a dedicated step to determine tags/version for both manual and dispatch-triggered releases, then propagates those outputs downstream.

  • Replace previous version output with new tag and multiline tags outputs
  • Add a GitHub Release step under the vars job that sets tag, version, and tags
  • Update downstream jobs (retag-images, resume-resources) to consume the new outputs
Comments suppressed due to low confidence (3)

.github/workflows/release.yml:23

  • The version output was removed from the vars job, but if any downstream jobs still reference needs.vars.outputs.version, they will break. Either reintroduce version or ensure all consumers are updated to use the new tags or tag outputs.
outputs:

.github/workflows/release.yml:42

  • [nitpick] Using a step id: release may be confusing since there is also a downstream job named release. Consider renaming the step to something like determine_release to avoid shadowing and improve clarity.
- name: GitHub Release

.github/workflows/release.yml:26

  • [nitpick] The output variable name tags is very generic and close to the singular tag. Renaming it to release_tags or similar could prevent confusion when reading or debugging the workflow.
tags: ${{ steps.release.outputs.tags }}

@mishraomp mishraomp merged commit 62ee73c into main Jun 17, 2025
21 checks passed
@mishraomp mishraomp deleted the fix/github-manual-release branch June 17, 2025 05:05
@github-project-automation github-project-automation Bot moved this from New to Done in NRIDS - Architecture Jun 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants