This repository was archived by the owner on Apr 30, 2026. It is now read-only.
fix: github manual relase#104
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the release workflow by introducing a dedicated step to determine tags/version for both manual and dispatch-triggered releases, then propagates those outputs downstream.
- Replace previous
versionoutput with newtagand multilinetagsoutputs - Add a
GitHub Releasestep under thevarsjob that setstag,version, andtags - Update downstream jobs (
retag-images,resume-resources) to consume the new outputs
Comments suppressed due to low confidence (3)
.github/workflows/release.yml:23
- The
versionoutput was removed from thevarsjob, but if any downstream jobs still referenceneeds.vars.outputs.version, they will break. Either reintroduceversionor ensure all consumers are updated to use the newtagsortagoutputs.
outputs:
.github/workflows/release.yml:42
- [nitpick] Using a step
id: releasemay be confusing since there is also a downstream job namedrelease. Consider renaming the step to something likedetermine_releaseto avoid shadowing and improve clarity.
- name: GitHub Release
.github/workflows/release.yml:26
- [nitpick] The output variable name
tagsis very generic and close to the singulartag. Renaming it torelease_tagsor similar could prevent confusion when reading or debugging the workflow.
tags: ${{ steps.release.outputs.tags }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.