Skip to content

Conversation

@filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Feb 6, 2025

Contains the following features:

Will be merged soon:

See according PR's for details

Todo

  • Clean to reduce size, now OVER deployment limit
  • Add tests for Nick's 7702 account initialization flow
  • Remove K1 validator, factory, tests (some tests can be moved to MEE k1 repo)

PR-Codex overview

This PR primarily focuses on enhancing the Nexus smart contract system by refining modules, improving signature validation, and adding new features for account management and execution.

Detailed summary

  • Updated accountId from biconomy.nexus.1.0.0 to biconomy.nexus.2.0.0 in multiple tests and contracts.
  • Added EmergencyUninstall struct in DataTypes.sol.
  • Introduced MockAccountLocker and MockPreValidationHook contracts.
  • Improved signature handling in MockMultiModule and related tests.
  • Updated NexusProxy and added proxy deployment logic in ProxyLib.
  • Implemented batch execution tests in TestAccountExecution_ExecuteBatch.
  • Added pre-validation hooks for ERC-1271 and ERC-4337.
  • Enhanced error handling with new custom errors in various contracts.
  • Refined gas settings and EVM version in configuration files.

The following files were skipped due to too many changes: test/foundry/unit/concrete/factory/TestK1ValidatorFactory_Deployments.t.sol, test/hardhat/smart-account/Nexus.Basics.specs.ts, test/foundry/unit/concrete/factory/TestAccountFactory_Deployments.t.sol, contracts/factory/RegistryFactory.sol, contracts/mocks/MockResourceLockPreValidationHook.sol, test/foundry/unit/concrete/nexus-sentinel-list/NexusSentinelListLib_Test.t.sol, contracts/factory/K1ValidatorFactory.sol, contracts/mocks/MockPreValidationHookMultiplexer.sol, contracts/lib/ExecLib.sol, test/foundry/unit/concrete/erc1271/TestERC1271Account_MockProtocol.t.sol, contracts/mocks/Mock7739PreValidationHook.sol, contracts/lib/NexusSentinelList.sol, test/foundry/integration/TestNexusPreValidation_Integration_ResourceLockHooks.t.sol, test/foundry/utils/TestHelper.t.sol, test/foundry/integration/TestNexusPreValidation_Integration_Multiplexer.t.sol, test/foundry/unit/concrete/modulemanager/TestModuleManager_EnableMode.t.sol, test/foundry/unit/concrete/eip7702/TestEIP7702.t.sol, contracts/Nexus.sol, contracts/base/ModuleManager.sol, test/foundry/unit/concrete/hook/TestNexus_Hook_Emergency_Uninstall.sol

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

highskore and others added 30 commits December 10, 2024 11:34
Remove dependency of tests on scripts
Signed-off-by: Manank Patni <manank321@gmail.com>
Fix test case for delegate call test_ExecuteDelegateCallFromExecutor_Success
Merge dev to add latest chanes re pre-validatiopn hook
@openzeppelin-code
Copy link

openzeppelin-code bot commented Feb 6, 2025

EIP-7702 + EP v0.8 Pre Release

Generated at commit: 2985f98b9ed0762644015fd73edcc65409ffb945

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
7
30
39

For more details view the full report in OpenZeppelin Code Inspector

@filmakarov filmakarov changed the title EIP-7702 + EP v0.8 Pre Release (Sepolia // 12th Feb) EIP-7702 + EP v0.8 Pre Release Feb 21, 2025
@github-actions
Copy link

🤖 Slither Analysis Report 🔎

Slither report

Details # Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)
🟡 - unused-return (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L189

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

lib/ExecLib.sol#L125-L139

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

@filmakarov filmakarov changed the title EIP-7702 + EP v0.8 Pre Release [Nexus 2.0.0] Release Nexus 2.0.0 : EIP-7702 + EP v0.8 Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants