Fix escapeAttr XSS, ExtensionAuth double fetch, and candidate page title

[bd73-com]

Summary

Fixes three browser extension and extension auth bugs reported in issues #242, #243, and #244. The escapeAttr function was missing ampersand escaping (XSS vector), the ExtensionAuth page fired duplicate POST requests on token fetch failure, and the candidate "Track this" button used the popup's own document.title instead of the target page's title.

Additionally hardens the ExtensionAuth error guard, extracts popup utilities into a testable module with 10 new tests, and rebuilds the extension ZIP as v1.0.3.

Changes

Bug fixes:

• escapeAttr now escapes & to & before other entity replacements, preventing HTML attribute injection (Bug: escapeAttr does not escape ampersand in popup HTML attributes #244)
• Removed error from useEffect dependency array in ExtensionAuth to prevent double POST on token fetch failure (Bug: ExtensionAuth useEffect fires twice on token fetch failure #243)
• Added error to the early-return guard to prevent implicit retries when user object reference changes
• Candidate "Track this" button now uses tab.title from chrome.tabs.query instead of the popup's document.title (Bug: Candidate 'Track this' button uses popup document.title instead of target page title #242)

Refactoring:

• Extracted escapeAttr and sanitizeTier into extension/src/popup/utils.ts for testability
• Added sync comment for KNOWN_TIERS referencing shared/models/auth.ts

Tests:

• Added extension/src/popup/utils.test.ts with 10 tests covering escapeAttr edge cases and sanitizeTier

Extension release:

• Bumped extension version to 1.0.3
• Rebuilt fetchthechange-extension.zip

Closes #242, closes #243, closes #244

How to test

1. Run npm run check && npm run test — 62 test files, 1717 tests pass
2. Install the rebuilt extension (extension/fetchthechange-extension.zip) in Chrome
3. Navigate to a page with & in the title, open popup, click "Track this" on a candidate — verify the monitor name input shows the correct page title with ampersands displayed properly
4. Navigate to /extension-auth while the token endpoint is returning errors — verify only one POST request is made (check Network tab)
5. Verify the default monitor name matches the target page's title, not "FetchTheChange" or empty

https://claude.ai/code/session_01AmZyEy5PWRPk34fqgyyUQ9

[coderabbitai]

Warning

Rate limit exceeded

@bd73-com has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 37 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 19dffe1a-018b-4e2d-ab39-8b180a708f4f

📥 Commits

Reviewing files that changed from the base of the PR and between 2527235 and d269e63.

⛔ Files ignored due to path filters (1)

• extension/fetchthechange-extension.zip is excluded by !**/*.zip

📒 Files selected for processing (5)

• client/src/pages/ExtensionAuth.tsx
• extension/manifest.json
• extension/src/popup/popup.ts
• extension/src/popup/utils.test.ts
• extension/src/popup/utils.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/fix-github-issues-69Kwf

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}