Fix: Add missing stripe and resend error log sources

[bd73-com]

Summary

• Add "stripe" and "resend" to the source filter allowlist in both GET /api/admin/error-logs and POST /api/admin/error-logs/batch-delete endpoints
• These sources were already written by ErrorLogger but could not be filtered in the admin panel

Test plan

• npm run check passes
• npm run test passes (1738 tests)
• Verify filtering by source=stripe returns only stripe error logs
• Verify filtering by source=resend returns only resend error logs
• Verify batch-delete with source filter works for new sources

Closes #260

https://claude.ai/code/session_01FfZuTLfQMSdpJZD78q8NXM

Summary by CodeRabbit

• New Features
  • Admin error-log filtering now accepts a broader set of sources (including scraper, email, scheduler, api, stripe, resend), giving Power-tier administrators improved visibility across more system components.
  • Source filter inputs are now validated against a centralized whitelist, reducing invalid filter results and making error-log searches more reliable.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 28349cb6-38ce-45b9-8b44-5db3885345f1

📥 Commits

Reviewing files that changed from the base of the PR and between 34c4c31 and 5d05dec.

📒 Files selected for processing (2)

• server/routes.ts
• shared/routes.ts

---

📝 Walkthrough

Walkthrough

Replaced inline error-log source allowlists with a shared ERROR_LOG_SOURCES constant and added a corresponding Zod enum; updated admin error-log endpoints to validate source against this shared whitelist.

Changes

Cohort / File(s)	Summary
Shared routes / schemas shared/routes.ts	Added exported ERROR_LOG_SOURCES (readonly literal array) and errorLogSourceSchema (Zod enum) to centralize allowed error-log source values.
Server admin endpoints server/routes.ts	Replaced inline source allowlist with import of ERROR_LOG_SOURCES; updated GET /api/admin/error-logs and POST /api/admin/error-logs/batch-delete to validate source against the shared constant.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Fix: Add missing stripe and resend error log sources #262 — also adjusts the admin error-log source whitelist and centralizes allowed sources for admin endpoints.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding 'stripe' and 'resend' to the error log source filter allowlist in admin endpoints.
Linked Issues check	✅ Passed	The code changes directly address issue #260 by extending the source allowlist from ['scraper', 'email', 'scheduler', 'api'] to include 'stripe' and 'resend' in both affected endpoints.
Out of Scope Changes check	✅ Passed	All changes are scoped to the stated objective: only the source allowlist values in error-log endpoints were modified; no unrelated alterations were introduced.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/fix-github-issue-bu8gp

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@server/routes.ts`:
- Around line 1435-1436: Create a shared constant and schema (e.g., export const
ERROR_LOG_SOURCES = ["scraper","email","scheduler","api","stripe","resend"] as
const; export const errorLogSourceSchema = z.enum(ERROR_LOG_SOURCES)) in the
shared module and import them via the `@shared/` alias; then replace every
hardcoded allowlist literal (the array used in the condition that checks
errorLogs.source and any other handlers that repeat the same array) with a
reference to ERROR_LOG_SOURCES for filtering and use errorLogSourceSchema to
validate/parse incoming source values before pushing conditions (i.e., replace
the inline ["scraper",...].includes(source) and similar checks with a
centralized import and validation).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 011a92ed-2376-49ef-ac74-dcb29a993842

📥 Commits

Reviewing files that changed from the base of the PR and between baddb93 and 34c4c31.

📒 Files selected for processing (1)

• server/routes.ts

[coderabbitai]

🛠️ Refactor suggestion | 🟠 Major

Centralize error-log source allowlist to prevent repeat regressions

The fix works, but the same source allowlist is still hardcoded in multiple handlers. That duplication caused this exact bug and will drift again. Move allowed sources to a shared constant/schema (e.g., in shared/routes.ts) and reuse it in both filters.

Proposed refactor

-      if (source && ["scraper", "email", "scheduler", "api", "stripe", "resend"].includes(source)) {
+      if (source && ERROR_LOG_SOURCES.includes(source as any)) {
         conditions.push(eq(errorLogs.source, source));
       }
...
-        if (filters.source && ["scraper", "email", "scheduler", "api", "stripe", "resend"].includes(filters.source)) {
+        if (filters.source && ERROR_LOG_SOURCES.includes(filters.source as any)) {
           conditions.push(eq(errorLogs.source, filters.source));
         }

// shared/routes.ts (or shared/constants/errorLogs.ts)
export const ERROR_LOG_SOURCES = [
  "scraper",
  "email",
  "scheduler",
  "api",
  "stripe",
  "resend",
] as const;
export const errorLogSourceSchema = z.enum(ERROR_LOG_SOURCES);

As per coding guidelines: “All types, schemas, and constants shared between client and server must live in the shared/ directory and be imported using the @shared/ path alias. Never duplicate shared types in client or server code.”

Also applies to: 1556-1557

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@server/routes.ts` around lines 1435 - 1436, Create a shared constant and
schema (e.g., export const ERROR_LOG_SOURCES =
["scraper","email","scheduler","api","stripe","resend"] as const; export const
errorLogSourceSchema = z.enum(ERROR_LOG_SOURCES)) in the shared module and
import them via the `@shared/` alias; then replace every hardcoded allowlist
literal (the array used in the condition that checks errorLogs.source and any
other handlers that repeat the same array) with a reference to ERROR_LOG_SOURCES
for filtering and use errorLogSourceSchema to validate/parse incoming source
values before pushing conditions (i.e., replace the inline
["scraper",...].includes(source) and similar checks with a centralized import
and validation).

Dismissing stale bot review — fixes were pushed in subsequent commits.