fix: always emit PEP-658/PEP-714 metadata attributes; doc them (#53) - #134
Draft
aiolibsbot wants to merge 2 commits into
Draft
aiolibsbot wants to merge 2 commits into
aiolibsbot wants to merge 2 commits into
Conversation
The anchor builder used `elif self.metadata_hash is not None`, so any wheel that declared `Requires-Python` (i.e. virtually every modern wheel) had its `data-dist-info-metadata` attribute suppressed even though the `.metadata` sidecar was being written to disk. Switch to a second `if` so both attributes can be emitted together, and add the PEP-714 alias `data-core-metadata` next to the legacy `data-dist-info-metadata`. README + docs now mention PEP-658/PEP-714 output as a first-class feature (closes bdraco#53). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Always emit the PEP-658 / PEP-714 metadata attributes on every wheel anchor, and document the feature in the README and Sphinx docs. Closes #53.
Why
The anchor builder in
wheel_file.pyusedelif self.metadata_hash is not None, which meant any wheel that declaredRequires-Python(i.e. virtually every modern wheel) had itsdata-dist-info-metadataattribute suppressed — even though the.metadatasidecar file was being written to disk. So pip never knew the sidecar existed and downloaded full wheels just to read METADATA.While fixing that, the project's docs never mentioned that
index-503actually generates PEP-658-compatible metadata (the point of issue #53).How
wheel_file.py: split theif/elifinto two independentifs so bothdata-requires-pythonand the metadata attributes can be emitted together. Handlemetadata_hash is True(no hash available) by emitting"true". Emit both PEP-714 (data-core-metadata) and the legacy PEP-658 (data-dist-info-metadata) names for compatibility.README.md: add a Features section that calls out PEP 503, PEP 658/714 sidecars,Requires-Python, and the cache.docs/usage.md: replace the placeholder with full CLI usage, install examples, and a Generated metadata section explaining the sidecar.tests/test_index.py: add regression assertions fordata-core-metadataand for a wheel withRequires-Pythonset (bleak) still advertising its metadata sidecar.Testing
pytest— 12737 passed locally.tests/test_index.pyexercise the regression onbleak-0.17.0(which hasRequires-Pythonset) — those assertions would fail without theif/elif → if/iffix.🤖 Generated with Claude Code
Quality Report
Changes: 4 files changed, 92 insertions(+), 6 deletions(-)
Code scan: clean
Tests: failed ([Errno 13] Permission denied: 'pytest')
Branch hygiene: 1 issue(s)
Generated by Kōan post-mission quality pipeline