Conversation
vsend_linef() formatted into a static buffer. send_line() waits for "ok" by polling the receive side, and the handlers it dispatches can call send_linef() again, overwriting the buffer before the outer command is transmitted. On a wired pendant this showed up as "$Files/ListGCode=/sd" reaching FluidNC as "/sd$G" (Bad path), plus a steady stream of error:3 from garbled commands. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The echo-off Ctrl-L was compiled out in any USE_WIFI build, but those builds can still be wired to FluidNC's UART. Echo then stays on, and an echoed "$..." line arriving mid-document resets the JSON parser. Decide at runtime instead. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waiting for "ok", which overwrote a command before it was sent. On a
wired M5Dial this turned "$Files/ListGCode=/sd" into "/sd$G" and caused a
stream of error:3.
to UART. It now depends on the transport in use.
Tested on an M5Dial wired to FluidNC over UART.