Conversation
show_error() reset the JSON depth and then called file_request_failed_advance(), whose first step is to skip the advance while a document is in progress. After the reset that check could never succeed. FluidNC can deliver an error for an earlier command while the next command's document is still arriving. The error then destroyed that healthy document and advanced the macro chain past it, showing "No Macros". Leave an in-flight document alone; the "ok" that ends it still resets the parser. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
service_config_requests() re-sent the front of the queue every 500 ms until a matching "$name=value" arrived. For a setting the machine doesn't have, such as an unconfigured axis, FluidNC replies with a bare error:3 that never matches, so the item stayed at the front forever. detect_homing_info() queues twelve of these on connect. One unanswerable item blocked the rest of the queue and flooded the link with error:3. - Drop an item as soon as FluidNC answers its query with an error. - As a fallback, drop it after four unanswered tries. - Don't send a request while a JSON document is streaming in, where the reply would corrupt it. A dropped item stays !known(), which its users already handle. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unconfigured axis) were retried every 500 ms forever. They blocked the
rest of the queue and flooded the link with error:3. They're now dropped
on the first error, or after four unanswered tries.
was in flight, so an error for an earlier command could destroy a healthy
macro file transfer.