Conversation
PreferencesListener never cleared _name, _target and _filename between macro entries, unlike the other macro listeners. An entry without an "action" reused the previous entry's filename, which already had its prefix, so it got a second one (shown as "//localfs/"). An entry without a "type" reused the previous type and was added when it should have been skipped. Clear the fields at the start of each entry, and skip entries with nothing to run. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreferencesListener didn't clear name/type/action between entries. An entry
missing a field inherited the previous entry's value, e.g. a filename that
was prefixed twice and shown as "//localfs/". The other macro listeners
already reset per entry.