Conversation
A successful $File/SendJSON never cleared s_pending_file_listener. Any later unrelated error:N, such as the config queries FluidNC rejects after connect, reached file_request_failed_advance() and advanced the chain anyway. That reported "No Macros" to whatever scene was open. Also reset _file_listener at the start of each document. It carried over from the last $File/SendJSON, so another document ending in an error status could advance the macro chain. A file that loads without any macros still falls through to the next source. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The macro chain only advanced on an error status or a bare error:N. If a response was cut short and neither arrived, the menu stayed on "Reading Macros" forever. Give up on a pending request after 5 s without data and move to the next source. The clock restarts with every chunk received, so a large file that is still arriving is never abandoned. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
refreshMacros() left the previous error string in place, and reDisplay() shows an error in preference to the "Reading Macros" placeholder. Refreshing after "No Macros" kept showing "No Macros" until the reload finished. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error:N then reported "No Macros" to whatever screen was open.
unrelated document can't advance the macro chain.
leaving "Reading Macros" up forever. The clock restarts with every chunk
received.