Conversation
The green button and a tap call invoke() without "Run", which opens the file preview. A "cmd:" macro has no file, so invoke() pushed the preview scene with a command line as its filename. The command could only be run from the dial. Run command macros directly from the green button and a tap, label the button "Run" for them, and never open the file preview for a command. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The green button and its legend only worked in Idle, but job-control commands are mostly useful while a job is held or running. The dial already runs commands in any state, just without a legend saying so. For command macros only, drop the Idle requirement from the green button and show the "Run" legends in any state. FluidNC still accepts or rejects each command. File macros are unchanged and still require Idle. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"cmd:" macros could only be run from the dial. The green button and a tap
tried to open a file preview for a command line.
and its legend are also available when the machine isn't idle, where
job-control commands are useful. File macros still require Idle.