Add utility function for real float conversion and update mode profile data handling#132
Merged
Conversation
…e data handling - Introduced `_as_real_float` function to safely convert values to real floats, handling None and empty arrays. - Updated `mode_profile_data` to use the new function for extracting the effective index (`neff`) from the mode source, ensuring proper handling of complex values. - Refactored the 3D waveguide example to improve structure and readability, encapsulating design creation and simulation setup in dedicated functions. - Added a test to verify that mode source profile data can accept complex `neff` values without warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_as_real_floatfunction to safely convert values to real floats, handling None and empty arrays.mode_profile_datato use the new function for extracting the effective index (neff) from the mode source, ensuring proper handling of complex values.neffvalues without warnings.