[Engine & Testing]: Reduced memory consumption to fit large sims into H100s and reduce sim compile time, slim down codebase, and avoid running complex tests#135
Merged
Conversation
…est case - Added source permittivity parameters to `apply_lossy_shell_from_lossless_3d` for improved handling of lossy shells in 3D simulations. - Introduced a new test to validate the use of permittivity in sparse 3D sponge PML configurations. - Ensured that the simulation correctly handles empty source conditions with the updated permittivity parameters.
…nce tests - Simplified the `fused_update_e_lossless_3d` function to conditionally handle source lossless conditions based on permittivity. - Introduced a new function `fused_update_e_lossless_3d_permittivity` for electric field updates considering permittivity. - Added tests to validate the correctness of electric field updates with permittivity in both sparse and dense configurations. - Improved the `fused_update_h_lossless_3d` function for clarity and performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
run_compilednow initializes fields to the compiled program precision, source patches and scan carries are cast back to carry dtype, CPML profiles preserve dtype, and snapshot indices avoid int32/int64 mismatches.docs/architecture/index.htmlwere deleted; several remaining examples were renamed to drop numeric prefixes.Why
The branch is mainly about reducing memory pressure and stabilizing compiled 3D FDTD execution: smaller CPML representation where possible, no sparse-shell special mode, less dense precomputation, compact ModeSource residuals, and fewer dtype/order-sensitive failures. The later test and example changes are about keeping CI/runtime costs down and removing old or expensive artifacts.