Fix Windows build: static CRT for vendored libjxl and .exe binary suffix#279
Merged
Conversation
jpegxl-src hardcodes CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded (static /MT) for libjxl on Windows MSVC, so the rest of the build must also use the static CRT or linking fails with LNK2038 RuntimeLibrary mismatches against dynamically-linked C deps (woff2/woofwoof, libwebp, etc.). Enable crt-static for x86_64-pc-windows-msvc. Also resolve the ddc binary name with std::env::consts::EXE_SUFFIX in the install and integration-test paths so they find ddc.exe on Windows instead of a bare ddc.
fasterthanlime
force-pushed
the
windows-build-fixes
branch
from
20eeda5 to
fe8552f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jpegxl-src hardcodes CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded (static /MT) for libjxl on Windows MSVC, so the rest of the build must also use the static CRT or linking fails with LNK2038 RuntimeLibrary mismatches against dynamically-linked C deps (woff2/woofwoof, libwebp, etc.). Enable crt-static for x86_64-pc-windows-msvc.
Also resolve the ddc binary name with std::env::consts::EXE_SUFFIX in the install and integration-test paths so they find ddc.exe on Windows instead of a bare ddc.