🧹 Gate legacy migration functions with #[cfg(windows)]

[bearice]

This change addresses a code health issue where legacy migration functions were marked with #[allow(dead_code)]. By replacing this with #[cfg(windows)], we ensure that the code is only compiled when needed (on Windows) and avoid dead code warnings on other platforms like macOS or Linux.

🎯 What: Gated migrate_from_numeric_id and get_theme_from_numeric_id with #[cfg(windows)].
💡 Why: These functions are platform-specific and only used in the Windows settings migration logic. Gating them is more precise than simply allowing dead code.
✅ Verification: Confirmed usages in src/platform/windows/settings.rs and verified they are not used in macOS code.
✨ Result: Improved maintainability and resolved dead code warnings correctly.

---

PR created automatically by Jules for task 10754752400106398428 started by @bearice

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[gemini-code-assist]

Summary of Changes

Hello @bearice, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances code health by implementing platform-specific conditional compilation for legacy migration functions. By gating these functions to compile only on Windows, it eliminates unnecessary code compilation and resolves dead code warnings on non-Windows operating systems, leading to a cleaner and more maintainable codebase.

Highlights

• Conditional Compilation: Replaced #[allow(dead_code)] with #[cfg(windows)] for migrate_from_numeric_id and get_theme_from_numeric_id functions in src/icon_manager.rs.
• Code Health: Ensured that Windows-specific migration functions are only compiled on Windows, preventing dead code warnings on other platforms like macOS and Linux.

Changelog

• src/icon_manager.rs
  • Replaced #[allow(dead_code)] with #[cfg(windows)] for the migrate_from_numeric_id function.
  • Replaced #[allow(dead_code)] with #[cfg(windows)] for the get_theme_from_numeric_id function.

Activity

• No human activity has occurred on this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly replaces #[allow(dead_code)] with #[cfg(windows)] for two legacy migration functions that are only used on the Windows platform. This is a good code health improvement, making the platform-specific nature of this code explicit and preventing dead code warnings on other platforms. I've added one suggestion for a potential future refactoring to further improve the code structure by co-locating this migration logic with its usage, but the current change is a solid step forward.

[gemini-code-assist]

While using #[cfg(windows)] is a definite improvement over #[allow(dead_code)], this change highlights a potential code organization improvement. Since both migrate_from_numeric_id and get_theme_from_numeric_id are legacy migration helpers used only on Windows, consider moving them into src/platform/windows/settings.rs.

This would offer several advantages:

• Improved Separation of Concerns: IconManager would be cleaner, containing only current, cross-platform logic.
• Co-location: The migration logic would live directly alongside its only point of use in migrate_legacy_settings.
• Better Encapsulation: The functions could be made private to the platform::windows::settings module, as they are implementation details of the Windows settings migration.

This refactoring would also make the #[cfg(windows)] attribute on these functions unnecessary, as the entire file is already Windows-specific.