fix(device-plugin): do not abort plugin start in case no device is found#16
Merged
dkeven merged 1 commit intofeat/nvsharefrom Mar 12, 2026
Merged
fix(device-plugin): do not abort plugin start in case no device is found#16dkeven merged 1 commit intofeat/nvsharefrom
dkeven merged 1 commit intofeat/nvsharefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
In #13, support for hot plug/unplug is added to device-plugin.
In rare cases, the nvidia driver loses control of the only GPU and reinitiates it shortly after. If this happens when the device plugin is starting, and before the reinitialization is finished, NVML may report no devices are found, causing device plugin to abort start, thus when the reinitialization finishes, the GPU still will not be reported by the device plugin. We make the case of no devices also eligible to restart device plugin after a delay.