fix(hami-scheduler): compatible with app's stop fast behavior#2712
Merged
fix(hami-scheduler): compatible with app's stop fast behavior#2712
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
eball
approved these changes
Mar 18, 2026
eball
added a commit
that referenced
this pull request
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
After appservice: stop app fast if pod was hami schudule failed when resume #2699, an Application that's reported unschedulable by hami-scheduler will be stopped immediately by app-service, however, hami-scheduler also reports unschedulable and make kube-sheduler retry scheduling in many retryable cases, such as node locked by another pod. Also, the asynchronous nature of HAMi's informer may lead to device occupation stats not updated immediately, causing pod to be scheduled only in the next retry. Two changes have been made to make HAMi compatible with this new logic:
1.Add a new event type reasoned as
InsufficientGPUthat's dedicated to the case when no available GPU resources can be found for the to-be scheduled pod, separating from other normal retryable cases.2.When pod is deleted by HAMi-scheduler itself, update the in-memory device usage immediately rather than relying on the pod informer to update the state, to avoid potential race conditions with the deployment controller.
Target Version for Merge
1.12.5, 1.12.6
Related Issues
none
PRs Involving Sub-Systems
fix(scheduler): compatible with app's stop fast behavior HAMi#17
Other information:
none