release: 0.2.1#48
Merged
Merged
Conversation
Three bugs fixed in one patch: 1. Manual upgrade from 0.1.x left the old binary, autostart entry, and Apps & Features Uninstall key in place, and could deadlock the state.db migration when a v0.1.x process was still running. Adds cleanup_legacy_install() that runs before migrations: kills other immichsync.exe instances, removes legacy binaries at %APPDATA%\ImmichSync and %APPDATA%\bees-roadhouse\immichsync, and clears stale Run / Uninstall registry entries when they point at a legacy path. 2. SHA-1 hash and upload-stream code paths trusted the watcher's placeholder filter, but a file can be evicted to the cloud after the watcher sees it and before queue/worker reads it. Reading the placeholder hydrates the whole file from the cloud — pages of bandwidth and CPU for a file the watcher would skip on its next pass. Adds is_online_file re-checks at queue-time (in process_file between metadata fetch and hash) and worker-time (in process_item before opening the file). Worker marks the entry "failed" with a descriptive message; the watcher's reconciliation re-enqueues when the file becomes local again. 3. Tray Quit and WM_QUIT waited up to 3s on pipeline.stop()'s graceful shutdown of in-flight uploads, making the tray feel laggy on exit. Adds shutdown_and_exit() — signals the watch engine + upload worker to stop, then process::exit(0). In-flight "uploading" rows are already reset to "pending" by reset_stale_uploading on next launch, so nothing is lost. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes v0.2.1 from development to release. Single bug-fix commit (#47).
Contents
Test plan