Selafin and damocles fixes - #10
Merged
Merged
Conversation
…ath one with buffer
…with other parse functions
I know there are variable to get the value of Pi... but here I don't want to do trigonometry, but testing parsing function with a known value
Some checks are only done in debug
That would create a non-conform cas file
now accept anything that can convert to a path
Consider a new block when meeting a new "NOM" or "NOM1". This is closer to what telemac does
In tomawac.dico, the level is negative
e.g. not only 3 levels of classification. Any number of level is possible
Only the last one is used to defined the GUI control
I have not idea of what are these GUI control. Just random guess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a bunch of fixes on selafin & damocles (steering files & dico files) parsing found during testing.
We are now more compatible with telemac files (including all dico & various steering files).