Integration of Proxy Vole

[serge-xav]

Integration of ProxyVole proposal.

Current behavior kept. Use the system properties use_proxy=proxy_vole to enable this new behavior.

[serge-xav]

I've changed my mind about current behavior for proxy search. By default proxy vole will be used, also if use_proxy system property is set to true. If set to "false", no proxy detection done. If set to "legacy", usage of old JRegistryKey way

[bekoenig]

Hello @serge-xav,

thanks for your improvement. The changes look good, but I'm a bit wary of ProxyVole. This project is outdated and it needs a lot of dependencies. Junit has compile scope, so I'm very skeptical.

[serge-xav]

Hi @bekoenig thanks for your reply, I've not seen the notification.

Understood your point on dependencies, but outdated is more valid for JRegistryKey than for Proxy-Vole I would say.

And as I said, JRegistryKey is of no use if you have a 64bit JVM running getdown.

[bekoenig]

Hi @serge-xav ,

I have to reject your PR. Proxy Vole is dead and has a lot of vulnerables (see here).

Inlining the code is also no option for me, because I don't use windows and have no experience in proxy detection. So I can't support any Issues for this implementation.

Many thanks for sharing your work.

Greetings,
Ben