Skip to content

Conversation

@belav
Copy link
Owner

@belav belav commented Jan 1, 2026

closes #1739

@belav belav force-pushed the rider-global-save branch from 3f0e7f0 to f773c27 Compare January 1, 2026 21:30
@belav belav force-pushed the rider-global-save branch 2 times, most recently from 070a265 to 2f0b44f Compare January 1, 2026 21:32
@belav belav merged commit 838b331 into main Jan 1, 2026
7 checks passed
@belav belav deleted the rider-global-save branch January 1, 2026 21:39
@TimothyMakkison
Copy link
Contributor

TimothyMakkison commented Jan 1, 2026

Hey @belav , I see you switched from strategy of migrating to a new property and instead opted to extend the existing one to be Boolean.

Did you confirm that this won't cause existing projects to ignore the global setting? My comment here goes into more detail.
I'm assuming Boolean defaults to null so any newly opened projects will use the global settings and won't have this issue.

I'm not sure how to test this, but I suspect it will be really annoying for users of it behaves this way

@belav
Copy link
Owner Author

belav commented Jan 5, 2026

@TimothyMakkison I confirmed that things all work as I expect them to. If an existing project has a value set it will ignore the global value. That is how it is supposed to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run on save being disabled in Rider plugin causes toil

3 participants