Skip to content

Avoid unrequested action manifest work in bound snapshots #121

Description

@ben-ranford

Outcome

Avoid cloning and validating the bound action manifest when a snapshot caller did not request actions.

Evidence

PR94 review #94 (comment) at53a035df02476da864af2b14c60b02be744edf9f. The bridge calls Registry.Manifest for each snapshot; the server validates those definitions and then drops them when includeActions is false or omitted. The wire result is correct, but large registries incur unnecessary polling work.

Acceptance

  • Carry includeActions request intent through private server/provider options and skip manifest assembly when omitted or false.
  • Preserve finalized Options.Actions ownership, including explicit nil, and existing direct callback behavior when no server request context exists.
  • Test true, false and omitted flags on full/patch server paths, plus direct-provider fallback.
  • Demonstrate reduced registry-related allocation/work with a controlled large registry; avoid wall-clock-only tests.
  • Preserve authorization, limits, diagnostics, wire encoding, Go floor and dependencies.

Scope relationship

Optional performance improvement beyond #62, which defines snapshot correctness and ownership but no registry-size polling budget. Related to #108 metadata-only snapshot projection, but independent: this change belongs in agent request plumbing and does not require a new session API. No v1.1.0 milestone assignment.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:coreSemantic, action, state, replay, and public core contractspriority:p2Normal milestone prioritytype:verificationExecutable compatibility, testing or release verification

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions