Skip to content

chore: remove templating logics#28

Merged
GregoryAlbouy merged 4 commits intomainfrom
chore/remove-templating
Aug 3, 2022
Merged

chore: remove templating logics#28
GregoryAlbouy merged 4 commits intomainfrom
chore/remove-templating

Conversation

@GregoryAlbouy
Copy link
Member

⚠️ #16 must be merged first

Description

Changes

Notes

Linked issues

@GregoryAlbouy GregoryAlbouy added the nice to have Non-blocking feature for the targeted release label Aug 1, 2022
@GregoryAlbouy GregoryAlbouy added this to the MVP milestone Aug 1, 2022
@GregoryAlbouy GregoryAlbouy force-pushed the chore/remove-templating branch from 0784ae6 to 338c30b Compare August 1, 2022 08:17
moreirathomas
moreirathomas previously approved these changes Aug 1, 2022
@moreirathomas
Copy link
Member

I approved even with the conflicts because I don't want to be blocking, I trust you to resolve them before merging.

@GregoryAlbouy GregoryAlbouy force-pushed the poc/test-suite branch 2 times, most recently from 29b0c26 to 54791be Compare August 2, 2022 19:17
@GregoryAlbouy GregoryAlbouy force-pushed the chore/remove-templating branch from 338c30b to 041d0d3 Compare August 3, 2022 18:42
@GregoryAlbouy GregoryAlbouy changed the base branch from poc/test-suite to main August 3, 2022 18:42
@GregoryAlbouy GregoryAlbouy dismissed moreirathomas’s stale review August 3, 2022 18:42

The base branch was changed.

@GregoryAlbouy GregoryAlbouy merged commit 29cd50e into main Aug 3, 2022
@moreirathomas moreirathomas deleted the chore/remove-templating branch August 19, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nice to have Non-blocking feature for the targeted release scope:cli scope:core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove templating logics

3 participants