Skip to content

docs: write main documentation#54

Merged
moreirathomas merged 4 commits intomainfrom
docs/main-docs
Oct 9, 2022
Merged

docs: write main documentation#54
moreirathomas merged 4 commits intomainfrom
docs/main-docs

Conversation

@GregoryAlbouy
Copy link
Member

@GregoryAlbouy GregoryAlbouy commented Oct 9, 2022

Description

Changes

Notes

Linked issues

@GregoryAlbouy GregoryAlbouy added documentation Improvements or additions to documentation must have Blocking feature for the targeted release scope:core labels Oct 9, 2022
@GregoryAlbouy GregoryAlbouy added this to the Next milestone Oct 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Merging #54 (264d89f) into main (be98e9c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   73.88%   73.88%           
=======================================
  Files          28       28           
  Lines         873      873           
=======================================
  Hits          645      645           
  Misses        203      203           
  Partials       25       25           
Flag Coverage Δ
unittests 73.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runner/runner.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

## About

:construction: WIP
Benchttp engine is a Go library providing a way to perform benchmarks and tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: it's not really a lib in the way that it only has one way to be used. I think package don't bring that weight of composability with it.

Suggested change
Benchttp engine is a Go library providing a way to perform benchmarks and tests
Benchttp engine is a Go library package a way to perform benchmarks and tests

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, package sound a little more suitable for me too.

Suggested change
Benchttp engine is a Go library providing a way to perform benchmarks and tests
Benchttp engine is a Go package providing a way to perform benchmarks and tests

Copy link
Member Author

@GregoryAlbouy GregoryAlbouy Oct 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it's still a library, as opposed to an executable application — I felt important to make that clear, as "package" is used for both worlds in Go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense too ! I leave judge on that :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong argument about it either, so OK for library if you prefer it.

Copy link
Contributor

@c1-ra c1-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@c1-ra c1-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@moreirathomas moreirathomas merged commit 42a0d59 into main Oct 9, 2022
@moreirathomas moreirathomas deleted the docs/main-docs branch October 9, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation must have Blocking feature for the targeted release scope:core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-write main documentation

4 participants