Skip to content

Fix analysis summary report not appearing after importing moves - #734

Draft
benckx with Copilot wants to merge 4 commits into
masterfrom
copilot/for-analysis-importing-moves
Draft

benckx with Copilot wants to merge 4 commits into
masterfrom
copilot/for-analysis-importing-moves

Conversation

Copilot AI commented May 28, 2026

Copy link
Copy Markdown
Contributor

When analysis is started by importing moves (rather than loading an existing game), the summary report was invisible until the user manually clicked the last node. This is because ImportMovesHandler sets MoveTreeWidget.#selectedNode internally without firing any listeners, leaving AnalysisBoardPage unaware of the new position — engine analysis continued on the start FEN and no summary check was triggered.

Changes

  • import-moves-handler.js — Added optional afterImportCallback (3rd param); invoked on successful import.
  • move-history-drop-down-menu.js — Threads an optional afterImportCallback (6th ctor param) through to the ImportMovesHandler it owns.
  • analysis-board.js — Both import entry points now pass a callback that calls #handleNodeSelected() (syncs engine to the imported position) and #scheduleRenderAnalysisSummaryIfPossible() (triggers immediate summary check if background analysis is already done):
() => {
    this.#handleNodeSelected();
    this.#scheduleRenderAnalysisSummaryIfPossible();
}

Copilot AI changed the title [WIP] Fix bug in summary report for analysis of imported moves Fix analysis summary report not appearing after importing moves May 28, 2026
Copilot finished work on behalf of benckx May 28, 2026 08:30
Copilot AI requested a review from benckx May 28, 2026 08:30
@benckx

benckx commented Jun 5, 2026

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

…s-importing-moves

# Conflicts:
#	webapp/src/main/resources/templates/about/changelog.html

Copilot AI commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Merged master into the branch and resolved the changelog conflict in 5cf6d55. The master's entries for 2026-05-29 through 2026-05-31 were inserted before our 2026-05-28 entry, keeping the date order correct.

Copilot finished work on behalf of benckx June 5, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

for analysis made not from an existing games but from e.g. importing moves, one must pick the last node to see the summary report (bug)

2 participants