Conversation
Copilot
AI
changed the title
[WIP] Fix bug in summary report for analysis of imported moves
Fix analysis summary report not appearing after importing moves
May 28, 2026
Owner
|
@copilot resolve the merge conflicts in this pull request |
…s-importing-moves # Conflicts: # webapp/src/main/resources/templates/about/changelog.html
Contributor
Author
Merged master into the branch and resolved the changelog conflict in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When analysis is started by importing moves (rather than loading an existing game), the summary report was invisible until the user manually clicked the last node. This is because
ImportMovesHandlersetsMoveTreeWidget.#selectedNodeinternally without firing any listeners, leavingAnalysisBoardPageunaware of the new position — engine analysis continued on the start FEN and no summary check was triggered.Changes
import-moves-handler.js— Added optionalafterImportCallback(3rd param); invoked on successful import.move-history-drop-down-menu.js— Threads an optionalafterImportCallback(6th ctor param) through to theImportMovesHandlerit owns.analysis-board.js— Both import entry points now pass a callback that calls#handleNodeSelected()(syncs engine to the imported position) and#scheduleRenderAnalysisSummaryIfPossible()(triggers immediate summary check if background analysis is already done):