Addressing PR comments by Copilot · Pull Request #781 · benckx/elephantchess

Copilot · 2026-06-09T06:40:10Z

No description provided.

benckx · 2026-06-09T06:55:00Z

    suspend fun listLastGames(
        limit: Int,
        statusToExcludes: List<GameEventType> = listOf(),
+        variantToInclude: Variant? = null,


@copilot should be a list that by default include all variants.

Updated in f07c340: listLastGames now takes variantsToInclude: List<Variant> = Variant.entries, so it defaults to all variants and supports subset filters (Manchu feed now passes listOf(Variant.MANCHU)).

benckx · 2026-06-09T06:55:43Z

@copilot drop the test

Done in 0fe1408: I dropped AdminFeedServiceTest.

benckx · 2026-06-09T06:56:05Z

        </tbody>
    </table>

+    <h1>Last Manchu Game Updates</h1>


@copilot make separate feed page

Done in 0fe1408 (with follow-up polish in d975c2f): Manchu games now have a separate page at /admin/manchu-feeds.

benckx

@copilot we also need to show manchu bot games

benckx · 2026-06-09T07:26:05Z

    get("/list-games") {
        requireAdminRole { adminFeedService.listLastGames() }
    }
+    get("/list-manchu-games") {


@copilot Generalize this to "variants" (i.e. non-xiangqi variants)

Done in 30c629f. I generalized the dedicated endpoints and feed logic to variants (non-Xiangqi): /list-variant-games and /list-variant-bot-games, backed by a shared non-Xiangqi variant filter instead of Manchu-only naming.

Copilot · 2026-06-09T07:35:12Z

@copilot we also need to show manchu bot games

Addressed in d3d4e40. The dedicated /admin/manchu-feeds page now also shows Manchu bot games via a new filtered admin endpoint (/api/admin/analytics/list-manchu-bot-games) and an added Manchu bot games table on that page.

Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/3e39c3d6-ad24-48f9-b67f-f09b50fe53f2 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>

Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/5b41f284-7e4c-44c3-aff1-e657cdbc5b05 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>

…u-games

Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/d9f48969-b3af-4bdf-9302-4e6e68dc2671 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>

benckx · 2026-06-09T15:25:36Z

@claude[agent] In fetchGameMetadata, is there a way to re-use the mappers that are defined at the bottom of the file?

The mappers at the bottom (mapPlayerVsBotGameToDto, mapPlayerVsPlayerGameToDto) are designed for list views and populate fields like redPlayerRating, redUserType, isRedOnline, etc., while fetchGameMetadata is for individual game detail and populates analysisStatus, engine, depth, startFen — fields the list mappers don't set.

The mappers also require a pre-computed onlineUserIds: Set<String> (batched from multiple records), which doesn't apply to a single-game lookup.

For the DB case there's no corresponding mapper at all — that logic lives only in fetchGameMetadata.

So no, they can't be reused as-is without restructuring those mappers. Let me know if you'd like me to refactor them to make reuse possible (e.g. make onlineUserIds optional, add the missing fields).

@claude[agent] I merged this PR. Do this in another PR. Just fill everything that can be filled each time.

Initial plan

301de59

Copilot AI assigned Copilot and benckx Jun 9, 2026

Copilot started work on behalf of benckx June 9, 2026 06:40 View session

Copilot AI linked an issue Jun 9, 2026 that may be closed by this pull request

add admin feed view for only manchu games #780

Closed

Add admin manchu-only game feed view

8b25d6f

Copilot AI changed the title ~~[WIP] Add admin feed view for Manchu games~~ Add Manchu-only admin game feed Jun 9, 2026

Copilot finished work on behalf of benckx June 9, 2026 06:52

Copilot AI requested a review from benckx June 9, 2026 06:52

benckx reviewed Jun 9, 2026

View reviewed changes

Copilot started work on behalf of benckx June 9, 2026 06:55 View session

benckx reviewed Jun 9, 2026

View reviewed changes

Refactor game variant filter to default list of variants

f07c340

Copilot finished work on behalf of benckx June 9, 2026 07:01

Copilot AI requested a review from benckx June 9, 2026 07:01

Copilot started work on behalf of benckx June 9, 2026 07:01 View session

Copilot AI added 3 commits June 9, 2026 07:09

Split Manchu feed into separate admin page

0fe1408

Align Manchu feed link labeling

163ae70

Remove redundant Manchu feed shortcut link

d975c2f

Copilot AI changed the title ~~Add Manchu-only admin game feed~~ Add separate Manchu-only admin game feed page Jun 9, 2026

Copilot finished work on behalf of benckx June 9, 2026 07:13

benckx requested changes Jun 9, 2026

View reviewed changes

Copilot started work on behalf of benckx June 9, 2026 07:25 View session

benckx reviewed Jun 9, 2026

View reviewed changes

Include Manchu bot games on dedicated admin feed page

d3d4e40

Copilot AI changed the title ~~Add separate Manchu-only admin game feed page~~ Add separate Manchu-only admin feeds page (PvP + bot games) Jun 9, 2026

Copilot finished work on behalf of benckx June 9, 2026 07:35

Copilot AI requested a review from benckx June 9, 2026 07:35

Copilot stopped work on behalf of benckx due to an error June 9, 2026 11:21
Claude Code process exited with code 1

Claude AI requested a review from benckx June 9, 2026 11:21

Claude started work on behalf of benckx June 9, 2026 11:24 View session

Move private mapper functions to bottom of AdminFeedService

4cabd61

Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/3e39c3d6-ad24-48f9-b67f-f09b50fe53f2 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>

Claude AI changed the title ~~Add separate non-Xiangqi variant admin feeds page (PvP + bot games)~~ Addressing PR comments Jun 9, 2026

Claude finished work on behalf of benckx June 9, 2026 11:29

benckx reviewed Jun 9, 2026

View reviewed changes

Comment thread ...rvice-layer/src/main/kotlin/io/elephantchess/servicelayer/services/admin/AdminFeedService.kt Outdated

Claude started work on behalf of benckx June 9, 2026 11:35 View session

Move companion object to bottom and include mapper functions

a37f4f6

Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/5b41f284-7e4c-44c3-aff1-e657cdbc5b05 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>

Copilot stopped work on behalf of benckx due to an error June 9, 2026 11:44
Claude Code process exited with code 1

Claude AI requested a review from benckx June 9, 2026 11:44

benckx changed the title ~~Addressing PR comments~~ add admin feed view for only manchu games Jun 9, 2026

benckx reviewed Jun 9, 2026

View reviewed changes

Comment thread webapp/src/main/resources/templates/admin/admin_variant_feeds.html

Claude started work on behalf of benckx June 9, 2026 12:17 View session

benckx and others added 3 commits June 9, 2026 14:18

merge branch 'master' into copilot/add-admin-feed-view-for-only-manch…

90f5204

…u-games

changelog

00becf3

Rename admin template from admin_manchu_feeds to admin_variant_feeds

06ab663

Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/d9f48969-b3af-4bdf-9302-4e6e68dc2671 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>

Copilot stopped work on behalf of benckx due to an error June 9, 2026 12:22
Claude Code process exited with code 1

Claude AI requested a review from benckx June 9, 2026 12:22

benckx added 4 commits June 9, 2026 17:11

admin console

c7d22e5

admin console

bc4af4b

re-organize

8b33cf2

re-organize

22e7e43

benckx reviewed Jun 9, 2026

View reviewed changes

Claude started work on behalf of benckx June 9, 2026 15:25 View session

Claude AI changed the title ~~add admin feed view for only manchu games~~ Addressing PR comments Jun 9, 2026

Claude AI requested a review from benckx June 9, 2026 15:27

Claude finished work on behalf of benckx June 9, 2026 15:27

benckx merged commit 781dace into master Jun 9, 2026
3 checks passed

benckx deleted the copilot/add-admin-feed-view-for-only-manchu-games branch June 9, 2026 15:29

Uh oh!

Conversation

Copilot AI commented Jun 9, 2026 • edited by Claude AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benckx Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

benckx Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

benckx Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

benckx left a comment

Choose a reason for hiding this comment

Uh oh!

benckx Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jun 9, 2026

Uh oh!

Uh oh!

Uh oh!

benckx Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Claude AI Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

benckx Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Jun 9, 2026 •

edited by Claude AI

Loading