fix: include schema.sql in package data - #57
Open
johnathanneals-dev wants to merge 1 commit into
Open
Conversation
The base schema file src/db/schema.sql was excluded from pip/pipx installs because the package-data glob only matched migrations/*.sql. Without it, non-Docker installs cannot bootstrap the database — the migration chain starts at 002 and assumes schema.sql was already applied. Add schema.sql to the src.db package-data glob so it ships with the wheel alongside the migrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54.
The base schema file
src/db/schema.sqlwas excluded from pip/pipx installs because thepyproject.tomlpackage-data glob only matchedmigrations/*.sql. Without it, non-Docker installs cannot bootstrap the database — the migration chain starts at002and assumesschema.sqlwas already applied.Adds
schema.sqlto thesrc.dbpackage-data glob so it ships with the wheel alongside the migrations.Change: one line in
pyproject.toml—"src.db" = ["migrations/*.sql"]→"src.db" = ["schema.sql", "migrations/*.sql"].