test: cover extended-character keys end-to-end - #17
Merged
Conversation
Closes #16 Validates ko's leveldb-backed storage and key.Match glob iteration against keys containing hyphens, dots, and underscores (UUIDs, ISO dates, filenames, snake_case identifiers). go.mod uses a TEMPORARY replace directive pointing to a local ooo checkout so the test can run before benitogf/ooo#73 is merged and tagged. Once ooo lands, bump the require to the released version and remove the replace directive. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
benitogf/ooo#73 is merged; switch to the released pseudo-version and remove the temporary replace directive that pointed at a local checkout. ko's extended-character key test now runs against the real published ooo. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
benitogf
marked this pull request as ready for review
May 12, 2026 05:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an end-to-end test that exercises ko's leveldb-backed storage with keys containing hyphens, dots, and underscores (UUIDs, ISO dates, filenames, snake_case identifiers).
Bumps ko's
ooodependency to include benitogf/ooo#73 (key.IsValid + routing widened to admit those characters) so the new test runs against the released code path.Test plan
-,., and_against ko's leveldb-backed storage.Closes #16
🤖 Generated with Claude Code