feat: add exponential backoff retry for webhook delivery#97
Open
bianbiandashen wants to merge 1 commit intobenjitaylor:mainfrom
Open
feat: add exponential backoff retry for webhook delivery#97bianbiandashen wants to merge 1 commit intobenjitaylor:mainfrom
bianbiandashen wants to merge 1 commit intobenjitaylor:mainfrom
Conversation
Webhooks now retry on transient failures with exponential backoff: - Retries on network errors, 5xx server errors, and 429 rate limiting - Exponential backoff with jitter to prevent thundering herd - Configurable via environment variables: - AGENTATION_WEBHOOK_MAX_RETRIES (default: 3) - AGENTATION_WEBHOOK_BASE_DELAY_MS (default: 1000) - AGENTATION_WEBHOOK_MAX_DELAY_MS (default: 30000) - AGENTATION_WEBHOOK_TIMEOUT_MS (default: 10000) - Non-blocking: retries run in background - Detailed logging for debugging retry behavior
|
@bianbiandashen is attempting to deploy a commit to the Benji Taylor's Projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add robust retry mechanism for webhook delivery using exponential backoff with jitter.
Problem
Currently, webhooks are fire-and-forget. If a webhook endpoint is temporarily unavailable (network glitch, server restart, rate limiting), the notification is lost forever.
Solution
Implement exponential backoff retry with the following features:
Retry Logic
baseDelay * 2^attemptwith configurable capConfiguration (Environment Variables)
AGENTATION_WEBHOOK_MAX_RETRIESAGENTATION_WEBHOOK_BASE_DELAY_MSAGENTATION_WEBHOOK_MAX_DELAY_MSAGENTATION_WEBHOOK_TIMEOUT_MSNon-blocking
Retries run in the background without blocking the HTTP response to the client.
Changes
mcp/src/server/http.ts: Add retry logic with helper functionsTest plan