Open
Conversation
barvian
force-pushed
the
unpause-fixes
branch
from
4038086 to
68f1ad9
Compare
During unpause catch-up, filterRight expanded past `now` as pauseProgress decayed, letting data points from the pause period (which have real-time timestamps ahead of the chart's lagging `now`) into the visible set. These mapped to X positions past the live tip, breaking the spline's monotone-X assumption and causing the line to extend past the dot. Fix: cap filterRight to `now` while time debt is active.
barvian
force-pushed
the
unpause-fixes
branch
from
6977ab9 to
5109f38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When unpausing I noticed the line draws ahead of the dot:
before.mov
I had Claude try to address this, and this is what it looks like now:
after.mov
It's still not quite as smooth as I would hope but I think it's a little better?