fix: improve online IP report handling#11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
ReportNodeOnlineUsersto returnerrwhencheckResponsefails by changingapi/panel/user.gotoreturn errinstead ofreturn nil.len(data) != 0guard innode/user.gobefore callingReportNodeOnlineUsersand add a concise debug log when filtering results in zero reported entries.Nodetype stringtoLimiter, changeAddLimitersignature toAddLimiter(nodetype string, tag string, ...)and initializeNodetypeinlimiter/limiter.go.CheckLimitconsiderhysteria2andtuicfor online-IP recording by updating the condition toif noSSUDP || l.Nodetype == "hysteria2" || l.Nodetype == "tuic", and update call sites innode/controller.goandnode/task.goto passnode.Type/newN.TypeintoAddLimiter./api/v1/server/UniProxy/aliveendpoint and payload typemap[int][]stringremain unchanged, and nonode_type=v2nodeor large refactors were introduced.Testing
gofmt -won modified files successfully.go build ./...and the build completed successfully.git diff --statand ensured the diff shows only the intended minimal modifications and no interface or payload changes.Codex Task