Fix alignment issues for strict architectures#32
Open
matoro wants to merge 2 commits intobestouff:masterfrom
Open
Fix alignment issues for strict architectures#32matoro wants to merge 2 commits intobestouff:masterfrom
matoro wants to merge 2 commits intobestouff:masterfrom
Conversation
DerDakon
reviewed
May 17, 2022
Fixes two locations where unaligned accesses will cause bus errors on architectures that are strict about such accesses, namely sparc. The first is in swab32_into, which is called with an offset of +1 into an unsigned char array from mklink_fs. The second is in add2fs_from_tarball when checking the validity of a tarball, which casts a string from an unaligned position inside a struct to a long. After these changes, the test suite passes on sparc.
sizeof(long) != 8 on 32-bit.
DerDakon
approved these changes
May 23, 2022
matoro
added a commit
to matoro/gentoo
that referenced
this pull request
Jul 13, 2022
Addresses https://bugs.gentoo.org/829270 by backporting my patch from bestouff/genext2fs#32 Bug: https://bugs.gentoo.org/828930 Closes: https://bugs.gentoo.org/829270 Signed-off-by: matoro <matoro@users.noreply.github.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 31, 2022
Addresses https://bugs.gentoo.org/829270 by backporting my patch from bestouff/genext2fs#32 Bug: https://bugs.gentoo.org/828930 Closes: https://bugs.gentoo.org/829270 Signed-off-by: matoro <matoro@users.noreply.github.com> Closes: #26332 Signed-off-by: Jakov Smolić <jsmolic@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two locations where unaligned accesses will cause bus errors on
architectures that are strict about such accesses, namely sparc.
The first is in swab32_into, which is called with an offset of +1 into
an unsigned char array from mklink_fs.
The second is in add2fs_from_tarball when checking the validity of a
tarball, which casts a string from an unaligned position inside a struct
to a long.
After these changes, the test suite passes on sparc.